[docs] Support demo previews with comments #3577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for custom preview blocks in demos. The current solution focuses heavily on a single jsx element, not configurable. For Toolpad we're in need of more flexibility. This PR proposes the extraction of previews using
// preview-start
and// preview-end
comment blocks. This allows for marking custom ranges as preview for demos, e.g.Will result in a preview of
instead of
We can clean up the full demo in the markdownloader and remove the lines containing
// preview-start
and// preview-end
. Additionally{/* preview-start */}
and{/* preview-end */}
are also supported to allow previewing specific JSX.It's also possible to delineate multiple preview blocks. They will get joined in the preview by a
// ...
Examples can be seen here: https://deploy-preview-3558--mui-toolpad-docs.netlify.app/toolpad/core/components/notifications/
tagging @mui/docs-infra wdyt?
Notes:
Also in this PR: run check in CI for formatted demos